Add support to auto calculate minion count for mods on Bonemeld and Farrul Bloodline#9832
Merged
LocalIdentity merged 2 commits intodevfrom May 4, 2026
Merged
Add support to auto calculate minion count for mods on Bonemeld and Farrul Bloodline#9832LocalIdentity merged 2 commits intodevfrom
LocalIdentity merged 2 commits intodevfrom
Conversation
added 2 commits
May 5, 2026 05:58
Automates the calc for the 2 config boxes so people don't need to manually work them out
For some reason the count of Animate weapon minions didn't use the same format as the other minion types so wasn't being counted in the total minion count calc Now will also show the minion max count in the sidebar too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Mods that relied on the number of minions or non-vaal minions summoned required the user to manually input the total count instead of us just auto-calculating it
-2% to all Resistances per Minion from your Non-Vaal Skills - Bonemeld
6% increased Defences per Minion from your Non-Vaal Skills - Bonemeld
4% increased Attack Speed per Minion, up to a maximum of 80% - Farrul Bloodline
1% additional Physical Damage Reduction per Minion, up to 10% - Necromancer Bone Barrier
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/a8691x0u
Before screenshot:
After screenshot: